mdmarshmallow commented on PR #11901: URL: https://github.com/apache/lucene/pull/11901#issuecomment-1320700985
Ah yeah good point on the FacetSets... so I actually already use `LongRangeDocValueFields` here: public class `LongRangeDocValuesFacetField extends LongRangeDocValuesField`. The difference is that the `LongRangeDocValuesFacetField` constructor enforces a single dimension. I'd imagine if we want to extend it, it shouldn't be that hard to just add another constructor here. With regards to this though: >As for how to handle faceting of multi-dim ranges, I think the logic would be the same as the "slow" query you reference, and would depend on the RangeFieldQuery#QueryType specified. I think I will need to change this PR a bit then. Right now what happens is that the query can have multiple ranges, which all need to "match" the stored range, which matches the "cross product" idea I talked about earlier which we won't be doing. So the way to go from here I think would be to either enforce only one range in the query, or just go ahead and do the multidimensional implementation. I think the latter makes more sense since I will need to change code either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
