mdmarshmallow commented on PR #11901: URL: https://github.com/apache/lucene/pull/11901#issuecomment-1319432286
Thanks for looking at this @gsmiller, I know it's a large PR. I based a lot of this off of `LongRangeSlowRangeQuery`, which does handle multidimensional fields. However, if I understand it correctly, it does so in a way that is similar to `FacetSets` where it treats all the dimensions as defining a hyper rectangle. By this I mean that input ranges are only compared with the stored range of the same dimension. I figured we shouldn't do that for `RangeOnRangeFacetCounts` as `FacetSets` already does this. So I guess I wasn't super sure on how to handle it? Like if we allow for multidimensional ranges, then should we make sure that every input range matches every stored range regardless of dimension (take a cross product)? I can add this if you think it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
