luyuncheng commented on PR #987: URL: https://github.com/apache/lucene/pull/987#issuecomment-1186947659
> Thanks for the iteration, the high-level idea looks good to me, I left some suggestions. @jpountz Thanks for your nice suggestions. at latest commits [ebcbdd](https://github.com/apache/lucene/commit/457bab5abfbaa3aabebe99a97e645b4f623be15f) 1. change statement byteBuffers in Lucene90CompressingStoredFieldsWriter 2. move sliceOne logic into ByteBuffersDataInput level and it would determine whether use internal buffers or create a new buffer 3. delete DeflateWithPresetDictCompressionMode#doCompress method which param is byte[] 4. delete copyOneDoc-> readBytes which instance ByteArrayDataInput optimize. and i would create a new issue to reduce memory copy in copyOneDoc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
