luyuncheng commented on code in PR #987: URL: https://github.com/apache/lucene/pull/987#discussion_r918848057
########## lucene/core/src/java/org/apache/lucene/codecs/compressing/CompressionMode.java: ########## @@ -257,9 +270,13 @@ private static class DeflateCompressor extends Compressor { } @Override - public void compress(byte[] bytes, int off, int len, DataOutput out) throws IOException { + public void compress(ByteBuffersDataInput buffersInput, int off, int len, DataOutput out) Review Comment: it is a nice suggestion, i try to use method `compress(CompositeByteBuf compositeByteBuf, DataOutput out) ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org