[GitHub] [lucene] luyuncheng commented on a diff in pull request #987: LUCENE-10627: Using ByteBuffersDataInput reduce memory copy on compressing data

[GitBox]

luyuncheng commented on code in PR #987:
URL: https://github.com/apache/lucene/pull/987#discussion_r925199019


##########
lucene/core/src/test/org/apache/lucene/codecs/lucene90/compressing/TestCompressingStoredFieldsFormat.java:
##########
@@ -325,4 +341,160 @@ public void testChunkCleanup() throws IOException {
     iw.close();
     dir.close();
   }
+
+  public void testSortedSetVariableLengthBigStoredFields() throws Exception {

Review Comment:
   In the 1st version, i try to use doc values check compressing and 
decompressing, and i founded it is same as `TestLucene90DocValuesFormat` 
testcase. 
   at commits 
[8c59d03](https://github.com/apache/lucene/pull/987/commits/8c59d035c504c9f51c8991a804f73d6ce7074449)
 i deleted `testSortedSetVariableLengthBigStoredFields`. 
   
   the compressing test case would using 
`TestDeflateWithPresetDictCompressionMode` and 
`TestLZ4WithPresetDictCompressionMode`
   
   and i added readNBytes test case in `TestByteBuffersDataInput`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org