vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1062441177
Thanks for reviewing this @mikemccand ! I've addressed the ones that had
minor changes, and am working on the larger ones.
> What remains to bring this out of WIP?
There are 2 existing tests that are breaking:
```java
- org.apache.lucene.index.TestAddIndexes.testAddIndicesWithSoftDeletes
(:lucene:core)
- org.apache.lucene.index.TestIndexSorting.testAddIndexesWithDeletions
(:lucene:core)
```
I've been looking at `testAddIndicesWithSoftDeletes`. IW does a
`rollbackInternal()` on shutDown, where it is failing on this assert - `assert
pendingNumDocs.get() == segmentInfos.totalMaxDoc()`. I'm guessing my code is
reserving more docs than it should.. is that the right direction?
Here's a longer error stack trace -
```java
java.lang.AssertionError: pendingNumDocs 7 != 5 totalMaxDoc
at
__randomizedtesting.SeedInfo.seed([63C0554849BFDEC5:4F94AA0CFCBAFADD]:0)
at
org.apache.lucene.index.IndexWriter.rollbackInternal(IndexWriter.java:2428)
at org.apache.lucene.index.IndexWriter.shutdown(IndexWriter.java:1334)
at org.apache.lucene.index.IndexWriter.close(IndexWriter.java:1362)
at org.apache.lucene.util.IOUtils.close(IOUtils.java:85)
at org.apache.lucene.util.IOUtils.close(IOUtils.java:72)
at
org.apache.lucene.index.TestAddIndexes.testAddIndicesWithSoftDeletes(TestAddIndexes.java:1521)
```
Outside of fixing existing tests, I want to add some new tests, especially
around cases where one of the merges fails, causing the whole API to fail (i.e.
test that transactionality was retained).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
