vigyasharma commented on a change in pull request #633:
URL: https://github.com/apache/lucene/pull/633#discussion_r827274463
##########
File path: lucene/core/src/java/org/apache/lucene/index/NoMergePolicy.java
##########
@@ -39,6 +40,11 @@ public MergeSpecification findMerges(
return null;
}
+ @Override
+ public MergeSpecification findMerges(List<CodecReader> readers) throws
IOException {
+ return null;
Review comment:
There are consumers of `NoMergePolicy` that expect
`addIndexes(CodecReaders...)` to work, like `IndexRearranger`. My understanding
is that NoMergePolicy is meant to turn off any merges on existing segments.
Since this API uses merges to add new readers to the index, I've changed it
here to return the default base class impl.
It's a little off because the name is NoMergePolicy, but I think(hope) it
aligns with the intent behind that class. I've added some comments to call this
out. Let me know if we should instead create a different MergePolicy that only
allows fineMerges(readers).. (it would be exactly like NoMergePolicy except for
one api).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
