gsmiller commented on a change in pull request #543:
URL: https://github.com/apache/lucene/pull/543#discussion_r779763050
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
##########
@@ -92,43 +113,71 @@ public LongValueFacetCounts(String field, LongValuesSource
valueSource, FacetsCo
* {@link org.apache.lucene.search.MatchAllDocsQuery}, but is more efficient.
*/
public LongValueFacetCounts(String field, IndexReader reader) throws
IOException {
- this(field, null, reader);
+ this(field, (MultiLongValuesSource) null, reader);
}
/**
* Counts all facet values for the provided {@link LongValuesSource} if
non-null. If {@code
* valueSource} is null, doc values from the provided {@code field} will be
used. This produces
* the same result as computing facets on a {@link
org.apache.lucene.search.MatchAllDocsQuery},
* but is more efficient.
+ *
Review comment:
I'm convinced (commented elsewhere on a similar comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
