gsmiller commented on pull request #543: URL: https://github.com/apache/lucene/pull/543#issuecomment-999132888
@romseygeek thanks for the feedback! I think it makes sense to keep these in the `facets` module for now and simplify where possible. Always easier to add new functionality than to take it away (or maintain it for no good reason) :). I think we still need `isCacheable` though for the query implementations in `LongRange` and `DoubleRange`. Does that seem right? Just published a new revision based on this feedback. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
