gsmiller commented on a change in pull request #543:
URL: https://github.com/apache/lucene/pull/543#discussion_r779761065
##########
File path: lucene/facet/src/java/org/apache/lucene/facet/range/DoubleRange.java
##########
@@ -222,8 +331,30 @@ public boolean isCacheable(LeafReaderContext ctx) {
*
* @param fastMatchQuery a query to use as a filter
* @param valueSource the source of values for the range check
+ * @deprecated Counting from a user-provided DoubleValuesSource is being
deprecated in favor of
Review comment:
I think that's fair. My motivation was to simplify the interface since
single-valued cases can be expressed as multi-valued (and then unwrapped), but
if users _know_ their data is single-valued already, it's probably more
complicated to ask them to wrap on their side. I'm convinced. Will bring these
back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
