romseygeek commented on pull request #543: URL: https://github.com/apache/lucene/pull/543#issuecomment-996645449
I know I originally suggested on the list that we could add the new abstractions to core, but I'm now wondering if it makes more sense to keep them in the facets module, given that they're not used elsewhere? It might be possible to simplify them a bit more as well then; e.g., I don't think we need `needsScores()` or `rewrite()` for facets, and possibly we don't need to worry about caching either given how these are used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
