uschindler commented on pull request #586: URL: https://github.com/apache/lucene/pull/586#issuecomment-1006640911
Hi Robert, I changed it. Also the Snowball check was at a bad place. The reflection logic was catching *all* exceptions so it swallowed the NPE. I also found a bug in Stempel (it was missing another `>=1` check for `minLength`). But when looking down the code the check was wrong, too: https://github.com/apache/lucene/pull/586/files#diff-9b6649212c96a6ce6627d2812723ffcff8dd70f6a8e28c4618041879e9d2651aL69 So i fixed this. What do you think about the stempel problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org