rmuir commented on pull request #586: URL: https://github.com/apache/lucene/pull/586#issuecomment-1006671945
> Also the Snowball check was at a bad place. The reflection logic was catching _all_ exceptions so it swallowed the NPE. Should we also change the catch block from `Exception` to `ReflectiveOperationException`? It will be tested, TestRandomChains will put bogus strings in there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org