mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r766510611
##########
File path: lucene/licenses/asm-analysis-7.2.jar.sha1
##########
@@ -0,0 +1 @@
+b6e6abe057f23630113f4167c34bda7086691258
Review comment:
Sorry if I was disturbing the conversation here; regarding the size of
added jars, simply adding them to the runtime seems fine (or at least it will
not be a major concern) to me as I mentioned.
+1 to keep it as-is (respecting the maintainers' intention).
If we ask the upstream project (asm) to reconsider the module structure or
even fork it, we'll need a spin-off issue I think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
