mocobeta commented on pull request #470: URL: https://github.com/apache/lucene/pull/470#issuecomment-981090868
I would recommend cherry-picking this clean-up https://github.com/apache/lucene/commit/57f695b14d8ad9f156bc06518a8c86058b813bd5. In regard to Luke, I had a concern about this external jar loading; just did a quick check, it works within JMS. https://github.com/apache/lucene/blob/main/lucene/luke/src/java/org/apache/lucene/luke/models/analysis/AnalysisImpl.java#L57 As the reflection stuff was gone in that commit and this plain class loading works fine (for me), I think there are no major error-prone parts remaining. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
