mocobeta commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r766414279
##########
File path: lucene/licenses/asm-analysis-7.2.jar.sha1
##########
@@ -0,0 +1 @@
+b6e6abe057f23630113f4167c34bda7086691258
Review comment:
Here is the size of jars ("asm-tree" and "asm-analysis"). We'll add them
to the runtime dependencies when running on module-mode if we don't take any
workarounds to get rid of them. Seems not so large to bother users (to me),
though I didn't measure the metaspace size those jars require.
```
lucene $ ls -lh
~/.gradle/caches/modules-2/files-2.1/org.ow2.asm/asm-tree/7.2/3a23cc36edaf8fc5a89cb100182758ccb5991487/
.rw-rw-r--@ 50k moco 4 12月 00:23 asm-tree-7.2.jar
lucene $ ls -lh
~/.gradle/caches/modules-2/files-2.1/org.ow2.asm/asm-analysis/7.2/b6e6abe057f23630113f4167c34bda7086691258/
.rw-rw-r--@ 33k moco 4 12月 00:23 asm-analysis-7.2.jar
```
Are there any other concerns I am missing here about simply adding those
jars (actually, not used jars) to the runtime...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
