dweiss commented on a change in pull request #470: URL: https://github.com/apache/lucene/pull/470#discussion_r760554212
########## File path: lucene/analysis/common/src/java-module/module-info.java ########## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/** Lucene Analysis Common. */ +module org.apache.lucene.analysis.common { + requires java.xml; + requires org.apache.lucene.core; + + exports org.apache.lucene.analysis.ar; + exports org.apache.lucene.analysis.bg; + exports org.apache.lucene.analysis.bn; + exports org.apache.lucene.analysis.boost; + exports org.apache.lucene.analysis.br; + exports org.apache.lucene.analysis.ca; + exports org.apache.lucene.analysis.charfilter; + exports org.apache.lucene.analysis.cjk; + exports org.apache.lucene.analysis.ckb; + exports org.apache.lucene.analysis.classic; + exports org.apache.lucene.analysis.commongrams; + exports org.apache.lucene.analysis.compound; + exports org.apache.lucene.analysis.core; + exports org.apache.lucene.analysis.custom; + exports org.apache.lucene.analysis.cz; + exports org.apache.lucene.analysis.da; + exports org.apache.lucene.analysis.de; + exports org.apache.lucene.analysis.el; + exports org.apache.lucene.analysis.email; + exports org.apache.lucene.analysis.en; + exports org.apache.lucene.analysis.es; + exports org.apache.lucene.analysis.et; + exports org.apache.lucene.analysis.eu; + exports org.apache.lucene.analysis.fa; + exports org.apache.lucene.analysis.fi; + exports org.apache.lucene.analysis.fr; + exports org.apache.lucene.analysis.ga; + exports org.apache.lucene.analysis.gl; + exports org.apache.lucene.analysis.hi; + exports org.apache.lucene.analysis.hu; + exports org.apache.lucene.analysis.hunspell; + exports org.apache.lucene.analysis.hy; + exports org.apache.lucene.analysis.id; + exports org.apache.lucene.analysis.in; + exports org.apache.lucene.analysis.it; + exports org.apache.lucene.analysis.lt; + exports org.apache.lucene.analysis.lv; + exports org.apache.lucene.analysis.minhash; + exports org.apache.lucene.analysis.miscellaneous; + exports org.apache.lucene.analysis.ne; + exports org.apache.lucene.analysis.ngram; + exports org.apache.lucene.analysis.nl; + exports org.apache.lucene.analysis.no; + exports org.apache.lucene.analysis.path; + exports org.apache.lucene.analysis.pattern; + exports org.apache.lucene.analysis.payloads; + exports org.apache.lucene.analysis.pt; + exports org.apache.lucene.analysis.query; + exports org.apache.lucene.analysis.reverse; + exports org.apache.lucene.analysis.ro; + exports org.apache.lucene.analysis.ru; + exports org.apache.lucene.analysis.shingle; + exports org.apache.lucene.analysis.sinks; + exports org.apache.lucene.analysis.snowball; + exports org.apache.lucene.analysis.sr; + exports org.apache.lucene.analysis.sv; + exports org.apache.lucene.analysis.synonym; + exports org.apache.lucene.analysis.ta; + exports org.apache.lucene.analysis.te; + exports org.apache.lucene.analysis.th; + exports org.apache.lucene.analysis.tr; + exports org.apache.lucene.analysis.util; + exports org.apache.lucene.analysis.wikipedia; + exports org.apache.lucene.collation; + + provides org.apache.lucene.analysis.CharFilterFactory with + org.apache.lucene.analysis.charfilter.HTMLStripCharFilterFactory, + org.apache.lucene.analysis.charfilter.MappingCharFilterFactory, + org.apache.lucene.analysis.cjk.CJKWidthCharFilterFactory, + org.apache.lucene.analysis.fa.PersianCharFilterFactory, + org.apache.lucene.analysis.pattern.PatternReplaceCharFilterFactory; + provides org.apache.lucene.analysis.TokenFilterFactory with + org.apache.lucene.analysis.tr.ApostropheFilterFactory, + org.apache.lucene.analysis.ar.ArabicNormalizationFilterFactory, + org.apache.lucene.analysis.ar.ArabicStemFilterFactory, + org.apache.lucene.analysis.bg.BulgarianStemFilterFactory, + org.apache.lucene.analysis.boost.DelimitedBoostTokenFilterFactory, + org.apache.lucene.analysis.bn.BengaliNormalizationFilterFactory, + org.apache.lucene.analysis.bn.BengaliStemFilterFactory, + org.apache.lucene.analysis.br.BrazilianStemFilterFactory, + org.apache.lucene.analysis.cjk.CJKBigramFilterFactory, + org.apache.lucene.analysis.cjk.CJKWidthFilterFactory, + org.apache.lucene.analysis.ckb.SoraniNormalizationFilterFactory, + org.apache.lucene.analysis.ckb.SoraniStemFilterFactory, + org.apache.lucene.analysis.classic.ClassicFilterFactory, + org.apache.lucene.analysis.commongrams.CommonGramsFilterFactory, + org.apache.lucene.analysis.commongrams.CommonGramsQueryFilterFactory, + org.apache.lucene.analysis.compound.DictionaryCompoundWordTokenFilterFactory, + org.apache.lucene.analysis.compound.HyphenationCompoundWordTokenFilterFactory, + org.apache.lucene.analysis.core.DecimalDigitFilterFactory, + org.apache.lucene.analysis.core.LowerCaseFilterFactory, + org.apache.lucene.analysis.core.StopFilterFactory, + org.apache.lucene.analysis.core.TypeTokenFilterFactory, + org.apache.lucene.analysis.core.UpperCaseFilterFactory, + org.apache.lucene.analysis.cz.CzechStemFilterFactory, + org.apache.lucene.analysis.de.GermanLightStemFilterFactory, + org.apache.lucene.analysis.de.GermanMinimalStemFilterFactory, + org.apache.lucene.analysis.de.GermanNormalizationFilterFactory, + org.apache.lucene.analysis.de.GermanStemFilterFactory, + org.apache.lucene.analysis.el.GreekLowerCaseFilterFactory, + org.apache.lucene.analysis.el.GreekStemFilterFactory, + org.apache.lucene.analysis.en.EnglishMinimalStemFilterFactory, + org.apache.lucene.analysis.en.EnglishPossessiveFilterFactory, + org.apache.lucene.analysis.en.KStemFilterFactory, + org.apache.lucene.analysis.en.PorterStemFilterFactory, + org.apache.lucene.analysis.es.SpanishLightStemFilterFactory, + org.apache.lucene.analysis.es.SpanishMinimalStemFilterFactory, Review comment: I've just committed a simple initial test showing how the distribution artifacts can be tested/ verified. I used aspectj - sorry but hamcrest is just too inconvenient to me - and added validation of module names and versions. A similar test should implement consistency checks for module/ manifest providers and other metadata. This should be a straightforward follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
