dweiss commented on a change in pull request #470:
URL: https://github.com/apache/lucene/pull/470#discussion_r766099602
##########
File path: gradle/java/jar-manifest.gradle
##########
@@ -69,12 +69,6 @@ subprojects {
"X-Build-OS" : "${System.properties['os.name']}
${System.properties['os.arch']} ${System.properties['os.version']}"
]
- // Only apply automatic module name to jar task.
- if (task.name in ["jar"]) {
- manifestAttrs["Automatic-Module-Name"] =
- "${-> project.path.replaceFirst(/^:lucene/,
Matcher.quoteReplacement(project.group)).replace(':', '.').replace('-', '_')}"
Review comment:
We do have a hardcoded list in that test? So it's a constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
