uschindler commented on a change in pull request #487: URL: https://github.com/apache/lucene/pull/487#discussion_r758744591
########## File path: gradle/java/jar-manifest.gradle ########## @@ -66,7 +66,7 @@ subprojects { "X-Build-JDK" : "${System.properties['java.version']} (${System.properties['java.vendor']} ${System.properties['java.vm.version']})", "X-Build-OS" : "${System.properties['os.name']} ${System.properties['os.arch']} ${System.properties['os.version']}", - "Automatic-Module-Name" : "${-> project.path.replaceFirst(":", "").replace(':', '.').replace("-", "_")}" + "Automatic-Module-Name" : "org.apache.${-> project.path.replaceFirst(":", "").replace(':', '.').replace("-", "_")}" Review comment: I committed my change. I will post the output on mailing list to get the others informed. Nevertheless we should still not make module system public for the 9.0 release, this may lead to too many questions. Once we have real module-info files and tested everything, we can make it public. By my complaint I just wanted to make sure that at least the module names are according to community standards and suggestions by Oracle. I know, @dweiss does not agree but let's present this to the committers on ML. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org