uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r759352578
##########
File path: lucene/CHANGES.txt
##########
@@ -247,7 +247,7 @@ API Changes
Improvements
---------------------
-* LUCENE-10234: Added Automatic-Module-Name to all JARs. This in a first step
to enable full Java
+* LUCENE-10234: Added Automatic-Module-Name to all JARs. This is the first
step to enable full Java
Review comment:
But to come back to your original question: This is an "improvement" (we
have module names now) and not a "build change" (yes it is a build change
technically, but it does not fix or change our build system as is).
So I would leave it where it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
