uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758715684



##########
File path: gradle/java/jar-manifest.gradle
##########
@@ -66,7 +66,7 @@ subprojects {
               "X-Build-JDK"           : "${System.properties['java.version']} 
(${System.properties['java.vendor']} ${System.properties['java.vm.version']})",
               "X-Build-OS"            : "${System.properties['os.name']} 
${System.properties['os.arch']} ${System.properties['os.version']}",
 
-              "Automatic-Module-Name" : "${-> project.path.replaceFirst(":", 
"").replace(':', '.').replace("-", "_")}"
+              "Automatic-Module-Name" : "org.apache.${-> 
project.path.replaceFirst(":", "").replace(':', '.').replace("-", "_")}"

Review comment:
       Hi, so it looks like this:
   
   ```
   > Task :showModuleNames
   lucene-benchmark-10.0.0-SNAPSHOT.jar               -> 
org.apache.lucene.benchmark
   lucene-backward-codecs-10.0.0-SNAPSHOT.jar         -> 
org.apache.lucene.backward_codecs
   lucene-classification-10.0.0-SNAPSHOT.jar          -> 
org.apache.lucene.classification
   lucene-codecs-10.0.0-SNAPSHOT.jar                  -> 
org.apache.lucene.codecs
   lucene-core-10.0.0-SNAPSHOT.jar                    -> org.apache.lucene.core
   lucene-demo-10.0.0-SNAPSHOT.jar                    -> org.apache.lucene.demo
   lucene-expressions-10.0.0-SNAPSHOT.jar             -> 
org.apache.lucene.expressions
   lucene-facet-10.0.0-SNAPSHOT.jar                   -> org.apache.lucene.facet
   lucene-grouping-10.0.0-SNAPSHOT.jar                -> 
org.apache.lucene.grouping
   lucene-highlighter-10.0.0-SNAPSHOT.jar             -> 
org.apache.lucene.highlighter
   lucene-join-10.0.0-SNAPSHOT.jar                    -> org.apache.lucene.join
   lucene-luke-10.0.0-SNAPSHOT.jar                    -> org.apache.lucene.luke
   lucene-memory-10.0.0-SNAPSHOT.jar                  -> 
org.apache.lucene.memory
   lucene-misc-10.0.0-SNAPSHOT.jar                    -> org.apache.lucene.misc
   lucene-monitor-10.0.0-SNAPSHOT.jar                 -> 
org.apache.lucene.monitor
   lucene-queries-10.0.0-SNAPSHOT.jar                 -> 
org.apache.lucene.queries
   lucene-queryparser-10.0.0-SNAPSHOT.jar             -> 
org.apache.lucene.queryparser
   lucene-replicator-10.0.0-SNAPSHOT.jar              -> 
org.apache.lucene.replicator
   lucene-sandbox-10.0.0-SNAPSHOT.jar                 -> 
org.apache.lucene.sandbox
   lucene-spatial-extras-10.0.0-SNAPSHOT.jar          -> 
org.apache.lucene.spatial_extras
   lucene-spatial3d-10.0.0-SNAPSHOT.jar               -> 
org.apache.lucene.spatial3d
   lucene-suggest-10.0.0-SNAPSHOT.jar                 -> 
org.apache.lucene.suggest
   lucene-test-framework-10.0.0-SNAPSHOT.jar          -> 
org.apache.lucene.test_framework
   lucene-analysis-common-10.0.0-SNAPSHOT.jar         -> 
org.apache.lucene.common
   lucene-analysis-icu-10.0.0-SNAPSHOT.jar            -> org.apache.lucene.icu
   lucene-analysis-kuromoji-10.0.0-SNAPSHOT.jar       -> 
org.apache.lucene.kuromoji
   lucene-analysis-morfologik-10.0.0-SNAPSHOT.jar     -> 
org.apache.lucene.morfologik
   lucene-analysis-nori-10.0.0-SNAPSHOT.jar           -> org.apache.lucene.nori
   lucene-analysis-opennlp-10.0.0-SNAPSHOT.jar        -> 
org.apache.lucene.opennlp
   lucene-analysis-phonetic-10.0.0-SNAPSHOT.jar       -> 
org.apache.lucene.phonetic
   lucene-analysis-smartcn-10.0.0-SNAPSHOT.jar        -> 
org.apache.lucene.smartcn
   lucene-analysis-stempel-10.0.0-SNAPSHOT.jar        -> 
org.apache.lucene.stempel
   ```
   
   I liked the previous names more, because now "analysis" is missing, @rmuir 
do you have any suggestion? Maybe we should do something like this:
   
   ```
   "${-> project.group.toString() + "." + project.path.replaceFirst(":lucene:", 
"").replace(':', '.').replace("-", "_")}"
   ```
   
   So maybe ask others on mailing list.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to