uschindler commented on a change in pull request #487:
URL: https://github.com/apache/lucene/pull/487#discussion_r758717236
##########
File path: gradle/java/jar-manifest.gradle
##########
@@ -66,7 +66,7 @@ subprojects {
"X-Build-JDK" : "${System.properties['java.version']}
(${System.properties['java.vendor']} ${System.properties['java.vm.version']})",
"X-Build-OS" : "${System.properties['os.name']}
${System.properties['os.arch']} ${System.properties['os.version']}",
- "Automatic-Module-Name" : "${-> project.path.replaceFirst(":",
"").replace(':', '.').replace("-", "_")}"
+ "Automatic-Module-Name" : "org.apache.${->
project.path.replaceFirst(":", "").replace(':', '.').replace("-", "_")}"
Review comment:
Anyways, thanks for fixing the bug with the wrong manifest on
non-library JARs (javadocs).
One thing to keep in mind: When we add module-info.java, we need to remove
the attribute, otherwise we have a duplicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
