rmuir commented on a change in pull request #348:
URL: https://github.com/apache/lucene/pull/348#discussion_r721235121
##########
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java
##########
@@ -103,6 +103,24 @@ public byte readByte() throws EOFException {
}
}
+ @Override
+ public short readShort() throws IOException {
+ // TODO: use ByteBuffer.getShort
Review comment:
does it make sense: when i add a TODO in this PR: means, "i don't have
the time/resources to fuck with this class", maybe because i don't understand
it, maybe because its complicated, etc. That also applies to sprinkling asserts
in the code as well as changing logic that isn't asserts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
