uschindler commented on a change in pull request #348:
URL: https://github.com/apache/lucene/pull/348#discussion_r721173204
##########
File path:
lucene/core/src/java/org/apache/lucene/store/InputStreamDataInput.java
##########
@@ -33,6 +33,21 @@ public byte readByte() throws IOException {
return (byte) v;
}
+ @Override
+ public short readShort() throws IOException {
+ return readShortSlowly();
+ }
+
+ @Override
+ public int readInt() throws IOException {
+ return readIntSlowly();
+ }
+
+ @Override
+ public long readLong() throws IOException {
+ return readLongSlowly();
+ }
Review comment:
That is more or less the same like OutputStreamIndexOutput, so
theoretically we could use the same trick. But I am not sure if this is
important here.
Unless there's a slowdown I wont do something like this. This would also
require to remove the BufferedOutputStream from the caller's code to prevent
double buffering (if the bufferring is implicitly added).
This is a separte issue (if required).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
