dweiss commented on a change in pull request #348:
URL: https://github.com/apache/lucene/pull/348#discussion_r721097179
##########
File path:
lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListReader.java
##########
@@ -319,6 +320,27 @@ public void readBytes(byte[] b, int offset, int len) {
pos += len;
}
+ @Override
+ public short readShort() throws IOException {
+ short value = (short) BitUtil.VH_LE_SHORT.get(pos);
+ pos += Short.BYTES;
+ return value;
+ }
+
+ @Override
+ public int readInt() throws IOException {
+ int value = (int) BitUtil.VH_LE_INT.get(pos);
+ pos += Integer.BYTES;
+ return value;
+ }
+
+ @Override
+ public long readLong() throws IOException {
Review comment:
> I think it is crazy to even attempt at a "rule" here.
Fair enough. I think it'd be good to state it explicitly somehow in the
javadoc. I'll do it as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
