dweiss commented on a change in pull request #348:
URL: https://github.com/apache/lucene/pull/348#discussion_r721096375
##########
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java
##########
@@ -103,6 +103,24 @@ public byte readByte() throws EOFException {
}
}
+ @Override
+ public short readShort() throws IOException {
+ // TODO: use ByteBuffer.getShort
Review comment:
I was referring to the TODO - the slow method has an explicit byte
order; when you switch to ByteBuffer.getShort it'd be safer to ensure the byte
order is what we expect it to be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]