sigram commented on a change in pull request #2179:
URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552527986
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##########
@@ -193,6 +195,22 @@ public PlacementPlan computePlacement(Cluster cluster,
PlacementRequest request,
Set<Node> nodes = request.getTargetNodes();
SolrCollection solrCollection = request.getCollection();
+ final SolrCollection secondaryCollection;
+ String withCollection =
solrCollection.getCustomProperty(CollectionAdminParams.WITH_COLLECTION);
Review comment:
I think that we should probably completely disallow using aliases in
this context... how would that work in practice? if you flip the alias that
used to point to the secondary collection to some other collection then
suddenly the co-location may be completely broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
