tflobbe commented on a change in pull request #2152:
URL: https://github.com/apache/lucene-solr/pull/2152#discussion_r549948394
##########
File path: solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java
##########
@@ -548,9 +548,6 @@ protected int sendDoc(int docId, Integer minRf, SolrClient
solrClient, String co
doc.addField("a_t", "hello" + docId);
UpdateRequest up = new UpdateRequest();
- if (minRf != null) {
- up.setParam(UpdateRequest.MIN_REPFACT, String.valueOf(minRf));
- }
Review comment:
> It appears that the minRf argument in sendDocsWithRetry is indeed
unused already but it might be clearer to tidy that up in a separate follow-up
pull request rather than mix it in here at this time.
I'm wondering if it would be better for this method to actually start using
this parameter, and retry in the case of `minRf` not achieved? This is not
something that was being done in this method, but may help improve some of the
tests using it. I don't think such a change should be done in this PR, but
maybe lets not remove the parameter yet then. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
