trdillon commented on pull request #2152: URL: https://github.com/apache/lucene-solr/pull/2152#issuecomment-751315270
> > > At https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.7.0/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java#L754-L756 there's also a `Implementing min_rf here was a bit tricky. ...` comment reference to `min_rf` -- any thoughts on either removing it or rewording it somehow? The comment still seems to be relevant and makes sense without the first sentence that references `minRf`. From my limited perspective I think it would be OK to just remove the first sentence. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
