trdillon commented on a change in pull request #2152:
URL: https://github.com/apache/lucene-solr/pull/2152#discussion_r547561917
##########
File path: solr/core/src/test/org/apache/solr/cloud/HttpPartitionTest.java
##########
@@ -548,9 +548,6 @@ protected int sendDoc(int docId, Integer minRf, SolrClient
solrClient, String co
doc.addField("a_t", "hello" + docId);
UpdateRequest up = new UpdateRequest();
- if (minRf != null) {
- up.setParam(UpdateRequest.MIN_REPFACT, String.valueOf(minRf));
- }
Review comment:
@cpoerschke Thanks for all your help with this one.
`sendDoc` seems OK to remove from `HttpPartitionTest` as it's only passed
`minRf` as an argument, but in `ReplicationFactorTest` it is passed
`expectedRf` as an argument in `addDocs`:
https://github.com/apache/lucene-solr/blob/98f12f4aeb9f6ec9f5c4de53f9faddc41043df59/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L417
`sendDocsWithRetry` is implemented here and used in a few different test
classes (`DistributedVersionInfoTest`, `LeaderFailoverAfterPartitionTest` and
`ForceLeaderTest`) with `minRf` as an argument:
https://github.com/apache/lucene-solr/blob/98f12f4aeb9f6ec9f5c4de53f9faddc41043df59/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java#L941
But it's also implemented using `expectedRfDBQ` and `expectedRf` in
`ReplicationFactorTest`:
-
https://github.com/apache/lucene-solr/blob/98f12f4aeb9f6ec9f5c4de53f9faddc41043df59/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L230
-
https://github.com/apache/lucene-solr/blob/98f12f4aeb9f6ec9f5c4de53f9faddc41043df59/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L427
I wasn't sure how to proceed with this as looking at the tests it seems that
`expectedRf` is relied upon quite often.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
