trdillon commented on a change in pull request #2152:
URL: https://github.com/apache/lucene-solr/pull/2152#discussion_r548939182
##########
File path: solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java
##########
@@ -461,38 +447,18 @@ protected void doDelete(UpdateRequest req, String msg,
int expectedRf, int retri
protected int sendDoc(int docId, int minRf) throws Exception {
UpdateRequest up = new UpdateRequest();
- boolean minRfExplicit = maybeAddMinRfExplicitly(minRf, up);
SolrInputDocument doc = new SolrInputDocument();
doc.addField(id, String.valueOf(docId));
doc.addField("a_t", "hello" + docId);
up.add(doc);
- return runAndGetAchievedRf(up, minRfExplicit, minRf);
+ return runAndGetAchievedRf(up);
Review comment:
The tests for `ReplicationFactorTest` and `HttpPartitionTest` passed on
my end after removing the `minRf` argument from `sendDoc`. I committed the
`ReplicationFactorTest` changes separately as it meant removing the
`expectedRf` argument from the `sendDoc` call in `addDocs` and I wasn't sure if
this was OK, even though the test still passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
