ErickErickson commented on a change in pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r547980795
##########
File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java
##########
@@ -35,12 +35,12 @@ public void testApplyUrlScheme() {
String liveNode1 = "192.168.1.1:8983_solr";
String liveNode2 = "127.0.0.1:8983_solr";
String liveNode3 = "127.0.0.1_";
- String liveNode4 = "127.0.0.1:61631_l_%2Fig";
+ String liveNode4 = "127.0.0.1:61631_lx%2Fig";
Review comment:
The changes to this test don't exercise the code change since they only
have one underscore. It would be better to leave liveNode4 alone, and add, say,
liveNode5 with a value like:
"127.0.0.1:61631_l_%2Fig_whatever"
Also see the comment in the JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
