thelabdude commented on a change in pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r549791687
##########
File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java
##########
@@ -35,12 +35,12 @@ public void testApplyUrlScheme() {
String liveNode1 = "192.168.1.1:8983_solr";
String liveNode2 = "127.0.0.1:8983_solr";
String liveNode3 = "127.0.0.1_";
- String liveNode4 = "127.0.0.1:61631_l_%2Fig";
+ String liveNode4 = "127.0.0.1:61631_lx%2Fig";
Review comment:
I think a good solution is to find the first underscore after the colon.
If you look at `generateNodeName` in ZkController then you'll see the colon is
always added to the generated `nodeName`. This may require some tests to update
the test node name as there are some tests that use an improper node name that
doesn't adhere to how `ZkController#generateNodeName` creates actual node names
at runtime, this seems like a bad test impl. to me and should be corrected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
