thelabdude commented on a change in pull request #2164:
URL: https://github.com/apache/lucene-solr/pull/2164#discussion_r549791973



##########
File path: solr/solrj/src/test/org/apache/solr/common/cloud/UrlSchemeTest.java
##########
@@ -35,12 +35,12 @@ public void testApplyUrlScheme() {
     String liveNode1 = "192.168.1.1:8983_solr";
     String liveNode2 = "127.0.0.1:8983_solr";
     String liveNode3 = "127.0.0.1_";
-    String liveNode4 = "127.0.0.1:61631_l_%2Fig";
+    String liveNode4 = "127.0.0.1:61631_lx%2Fig";

Review comment:
       fwiw ~ you can't look at the last underscore because nodeName encoding 
changes `/` to `_` in the context as you can't create znodes with `/` in them 
for obvious reasons ;-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to