jpountz commented on a change in pull request #1976:
URL: https://github.com/apache/lucene-solr/pull/1976#discussion_r503439534
##########
File path: lucene/core/src/java/org/apache/lucene/util/automaton/Automata.java
##########
@@ -254,7 +254,7 @@ public static Automaton makeBinaryInterval(BytesRef min,
boolean minInclusive, B
cmp = min.compareTo(max);
} else {
cmp = -1;
- if (min.length == 0 && minInclusive) {
+ if (min.length == 0) {
Review comment:
this looks wrong as we should still make sure that the empty string is
rejected if min=="" and minInclusive==false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
