cbuescher commented on a change in pull request #1976:
URL: https://github.com/apache/lucene-solr/pull/1976#discussion_r505373344
##########
File path: lucene/core/src/java/org/apache/lucene/util/automaton/Automata.java
##########
@@ -85,7 +85,15 @@ public static Automaton makeAnyBinary() {
a.finishState();
return a;
}
-
+
+ /**
+ * Returns a new (deterministic) automaton that accepts all binary terms
except
+ * the empty string.
+ */
+ public static Automaton makeAnyBinaryExceptEmpty() {
+ return makeCharRange(0, 255);
Review comment:
Yes, I was missing that this doesn't include a self-referencing accept
state. Fixed that and added more tests to check this is working now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
