cbuescher opened a new pull request #1976:
URL: https://github.com/apache/lucene-solr/pull/1976


   # Description
   
   Currently a TermRangeQuery with the empty String ("") as lower bound and
   includeLower=false leads internally constructs an Automaton that doesn't 
match
   anything. This is unexpected expecially for open upper bounds where any 
string
   should be considered to be "higher" than the empty string.
   
   # Solution
   
   This PR changes "Automata#makeBinaryInterval" so that for an empty string 
lower
   bound and an open upper bound, any String should match the query regardless 
or
   the includeLower flag.
   
   # Tests
   
   Added two new tests to `TestAutomaton`.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `./gradlew check`
   - [x] I have added tests for my changes.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to