rmuir commented on pull request #1802: URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-683374849
I ran a quick benchmark of just the javadoc task of `master` vs `LUCENE-9215` branch: `./gradlew clean compileJava && time ./gradlew javadoc` master: BUILD SUCCESSFUL in 3m 21s LUCENE-9215: BUILD SUCCESSFUL in 3m 22s So this check pass is effectively free and doesn't slow down javadoc processing at all (the hard part is already done), and I think it is a lot easier dealing with the errors directly from `gradlew javadoc`: things like filenames and line numbers really help. Plus we remove the previous python script which was recursively parsing HTML, and that thing was never instant. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
