madrob commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468221630
##########
File path: lucene/core/src/java/org/apache/lucene/index/DocValuesUpdate.java
##########
@@ -152,12 +152,12 @@ static BytesRef readFrom(DataInput in, BytesRef scratch)
throws IOException {
}
NumericDocValuesUpdate(Term term, String field, Long value) {
- this(term, field, value != null ? value.longValue() : -1,
BufferedUpdates.MAX_INT, value != null);
+ this(term, field, value != null ? value : -1, BufferedUpdates.MAX_INT,
value != null);
}
- private NumericDocValuesUpdate(Term term, String field, long value, int
docIDUpTo, boolean hasValue) {
Review comment:
There were 16 instances of `Upto` and 4 of `UpTo` so I went with the
more common one for consistency. Happy to switch the other way if it's more
correct according to English. Looking it up now and looks like "upto" isn't a
word?
##########
File path:
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterFlushControl.java
##########
@@ -324,12 +324,12 @@ synchronized void doOnAbort(DocumentsWriterPerThread
perThread) {
}
}
- private void checkoutAndBlock(DocumentsWriterPerThread perThread) {
+ private synchronized void checkoutAndBlock(DocumentsWriterPerThread
perThread) {
Review comment:
I'll split this out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
