[
https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161426#comment-17161426
]
Munendra S N commented on SOLR-14583:
-------------------------------------
The expectation is that {{maxResultsForSuggest=0}} with onlyMorePopular
enabled, and number of doc hits is greater than 0, suggestion shouldn't be
returned but currently, it does return the suggestion. The same doesn't happen
if {{maxResultsForSuggest>0}} with onlyMorePopular is enabled.
The above behavior is consistent with either extendedResults enabled or
disabled.
{quote}In any case, we probably shouldn't make breaking API changes unless we
can demonstrate a clear benefit to the user{quote}
+1. Even we decide to allow user to specify suggestMode, it could behave
similar to facet.method in json facet where specified value along with other
conditions(field type,multivalued) is considered before choosing the facet
method. Similarly, spellcheck component choose the mode based on the
combination of specified value and other conditions like hits but that would
entirely be different task.
> Spell suggestion is returned even if hits are non-zero when
> spellcheck.maxResultsForSuggest=0
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-14583
> URL: https://issues.apache.org/jira/browse/SOLR-14583
> Project: Solr
> Issue Type: Bug
> Reporter: Munendra S N
> Assignee: Munendra S N
> Priority: Major
> Attachments: SOLR-14583.patch, SOLR-14583.patch
>
>
> SOLR-4280 added to support fractional support for
> spellcheck.maxResultsForSuggest. After SOLR-4280,
> {{spellcheck.maxResultsForSuggest=0}} is treated same as not specify the
> {{spellcheck.maxResultsForSuggest}} parameter. This can cause spell
> suggestions to be returned even when hits are non-zero and greater than
> {{spellcheck.maxResultsForSuggest}} (i.e, greater than 0)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
