[
https://issues.apache.org/jira/browse/SOLR-14583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161361#comment-17161361
]
James Dyer commented on SOLR-14583:
-----------------------------------
[~munendrasn] Taking a quick look at the test changes in your last patch, I
surmise you are finding it does not work correctly when extended results are
turned off? Or, can you describe the problem in detail?
I think the reason we do not expose the suggest mode directly is that it
decides which one to use mid-query. That is, if the results come back and it is
less than "alternativeTermCount", it uses "suggest always" otherwise it uses
"suggest when not in index". Perhaps my memory on this is too faded.
In any case, we probably shouldn't make breaking API changes unless we can
demonstrate a clear benefit to the user. I do agree the current spellcheck is
difficult for users to configure.
> Spell suggestion is returned even if hits are non-zero when
> spellcheck.maxResultsForSuggest=0
> ---------------------------------------------------------------------------------------------
>
> Key: SOLR-14583
> URL: https://issues.apache.org/jira/browse/SOLR-14583
> Project: Solr
> Issue Type: Bug
> Reporter: Munendra S N
> Assignee: Munendra S N
> Priority: Major
> Attachments: SOLR-14583.patch, SOLR-14583.patch
>
>
> SOLR-4280 added to support fractional support for
> spellcheck.maxResultsForSuggest. After SOLR-4280,
> {{spellcheck.maxResultsForSuggest=0}} is treated same as not specify the
> {{spellcheck.maxResultsForSuggest}} parameter. This can cause spell
> suggestions to be returned even when hits are non-zero and greater than
> {{spellcheck.maxResultsForSuggest}} (i.e, greater than 0)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
