CaoManhDat commented on a change in pull request #1470:
URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418416790



##########
File path: 
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttp2SolrClient.java
##########
@@ -66,4 +80,132 @@ public LBHttp2SolrClient(Http2SolrClient httpClient, 
String... baseSolrUrls) {
   protected SolrClient getClient(String baseUrl) {
     return httpClient;
   }
+
+  public interface OnComplete {

Review comment:
       Hmm, so the to OnComplete different in the parameter of `onSuccess` one 
is 
   * NamedList
   * another is LBSolrClient.Rsp
   Should we making them as template then move it to util package of solrj?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to