CaoManhDat commented on a change in pull request #1470:
URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418394131
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java
##########
@@ -64,18 +62,23 @@
* by the RealtimeGet handler, since other types of replicas shouldn't
respond to RTG requests
*/
public static String ONLY_NRT_REPLICAS = "distribOnlyRealtime";
+ private static final ShardResponse END_QUEUE = new ShardResponse();
private HttpShardHandlerFactory httpShardHandlerFactory;
- private CompletionService<ShardResponse> completionService;
- private Set<Future<ShardResponse>> pending;
+ private LinkedList<Cancellable> requests;
Review comment:
I think most of the time, max size of the list will equals to number of
shards, so I think it won't be very different here but I can change it back to
ArrayList.
> I also don't see us removing requests anywhere?
That is right, we need to remove elements from this list on the
corresponding result arrived.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
