madrob commented on a change in pull request #1470:
URL: https://github.com/apache/lucene-solr/pull/1470#discussion_r418628204
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java
##########
@@ -54,6 +53,10 @@
import org.apache.solr.util.tracing.GlobalTracer;
import org.apache.solr.util.tracing.SolrRequestCarrier;
+/**
+ * Submit requests in async manner.
+ * This class is not thread-safe so all methods should be called in a same
thread.
Review comment:
Use `@SolrSingleThreaded`
##########
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java
##########
@@ -259,12 +261,10 @@ private ShardResponse take(boolean bailOnError) {
@Override
public void cancelAll() {
- for (Cancellable cancellable : requests) {
+ for (Cancellable cancellable : responseCancellableMap.values()) {
Review comment:
And clear the map?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
