[ https://issues.apache.org/jira/browse/SOLR-14370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073824#comment-17073824 ]
Mike Drob commented on SOLR-14370: ---------------------------------- How does this relate to [https://cwiki.apache.org/confluence/display/SOLR/SIP-6+Solr+should+own+the+bootstrap+process] and if we adopt that, then does this still have a place? Note that this could be a short-lived fix until we overhaul the bootstrap process, but that need not block this change. cc: [~janhoy] > Refactor bin/solr to allow external override of Jetty modules > ------------------------------------------------------------- > > Key: SOLR-14370 > URL: https://issues.apache.org/jira/browse/SOLR-14370 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools > Reporter: Andy Throgmorton > Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > The bin/solr script currently does not allow for externally overriding the > modules passed to Jetty on startup. > This PR adds the ability to override the Jetty modules on startup by setting > {{JETTY_MODULES}} as an environment variable; when passed, bin/solr will pass > through (and not clobber) the string verbatim into {{SOLR_JETTY_CONFIG}}. For > example, you can now run: > {{JETTY_MODULES=--module=foo bin/solr start}} > We've added some custom Jetty modules that can be optionally enabled; this > change allows us to keep our logic (regarding which modules to use) in a > separate script, rather than maintaining a forked bin/solr. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org