[
https://issues.apache.org/jira/browse/SOLR-14370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074613#comment-17074613
]
David Smiley commented on SOLR-14370:
-------------------------------------
Andy, maybe you could explain a higher level goal and how this particular issue
helps meet that goal. That may lead to more sympathy to this approach, or it
could lead to alternative ideas.
> Refactor bin/solr to allow external override of Jetty modules
> -------------------------------------------------------------
>
> Key: SOLR-14370
> URL: https://issues.apache.org/jira/browse/SOLR-14370
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: scripts and tools
> Reporter: Andy Throgmorton
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The bin/solr script currently does not allow for externally overriding the
> modules passed to Jetty on startup.
> This PR adds the ability to override the Jetty modules on startup by setting
> {{JETTY_MODULES}} as an environment variable; when passed, bin/solr will pass
> through (and not clobber) the string verbatim into {{SOLR_JETTY_CONFIG}}. For
> example, you can now run:
> {{JETTY_MODULES=--module=foo bin/solr start}}
> We've added some custom Jetty modules that can be optionally enabled; this
> change allows us to keep our logic (regarding which modules to use) in a
> separate script, rather than maintaining a forked bin/solr.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
