[
https://issues.apache.org/jira/browse/SOLR-14378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17073787#comment-17073787
]
Christine Poerschke commented on SOLR-14378:
--------------------------------------------
Attached proposed patch.
I'm unsure on whether or not a solr/CHANGES.txt entry for this would be
appropriate though:
* on the one hand something like "Factor a FilterFeatureScorer class out from
(contrib/ltr) OriginalScoreScorer." under the "Other Changes" section seems too
close to the code and an implementation detail.
* on the other hand this is not a literal factoring out i.e. the factored out
class delegates more methods than the OriginalScoreScorer did (but the
practical impact of that I'm not yet clear on, other than that the tests
continue to pass).
> factor out a (contrib/ltr) FilterFeatureScorer class
> ----------------------------------------------------
>
> Key: SOLR-14378
> URL: https://issues.apache.org/jira/browse/SOLR-14378
> Project: Solr
> Issue Type: Task
> Components: contrib - LTR
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-14378.patch
>
>
> It looks like a {{FilterFeatureScorer}} class can be factored out from
> {{OriginalScoreScorer}} (and {{SolrFeatureScorer}} after or with [~dsmiley]'s
> SOLR-14364 changes could use it too).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
