mikemccand commented on a change in pull request #1274: LUCENE-9164: Prevent IW
from closing gracefully if threads are still modifying
URL: https://github.com/apache/lucene-solr/pull/1274#discussion_r387129182
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -2244,21 +2233,22 @@ public void rollback() throws IOException {
// Ensure that only one thread actually gets to do the
// closing, and make sure no commit is also in progress:
if (shouldClose(true)) {
- rollbackInternal();
+ rollbackInternal(true);
}
}
- private void rollbackInternal() throws IOException {
+ private void rollbackInternal(boolean gracefully) throws IOException {
Review comment:
Can you add private javadocs explaining what `gracefully` means?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
