mikemccand commented on a change in pull request #1274: LUCENE-9164: Prevent IW
from closing gracefully if threads are still modifying
URL: https://github.com/apache/lucene-solr/pull/1274#discussion_r386976022
##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
##########
@@ -1444,6 +1446,7 @@ public synchronized long tryUpdateDocValue(IndexReader
readerIn, int docID, Fiel
}
private synchronized long tryModifyDocument(IndexReader readerIn, int docID,
DocModifier toApply) throws IOException {
+ // no modificationLease allowed here since we are synchronized on the IW
Review comment:
Maybe change `allowed` to `needed`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
