s1monw commented on issue #1274: LUCENE-9164: Prevent IW from closing gracefully if threads are still modifying URL: https://github.com/apache/lucene-solr/pull/1274#issuecomment-593843314 > This looks great. I've gone through all methods in IndexWriter. I think prepareCommitInternal, tryModifyDocument, and deleteUnusedFiles should be executed under a modification lease. Thanks for checking this. We can't and shouldn't ever acquire a modification lease while we are inside a `synchronized(this)` block. I know concurrency is a little mess in IW and needs to be reworked. I do have some ideas for this to streamline it more or at lease make it less trappy. I left some comments. For `prepareCommitInternal` we own the `commitLock` so we are good to go too.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
